Skip to content

replace int with i32#202

Merged
kbkpbot merged 1 commit into
vlang:masterfrom
kbkpbot:replace-int-with-i32
Sep 12, 2025
Merged

replace int with i32#202
kbkpbot merged 1 commit into
vlang:masterfrom
kbkpbot:replace-int-with-i32

Conversation

@kbkpbot

@kbkpbot kbkpbot commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

As vlang/v#25236 may change int a platform dependent 32/64 bit integer, all int from a C program should translate to i32 in v.

@kbkpbot kbkpbot merged commit c024e9e into vlang:master Sep 12, 2025
@spytheman

Copy link
Copy Markdown
Contributor

@kbkpbot why did you delete tests/test.c/1.hello.c and tests/test.c/1.hello.out ?

@spytheman

spytheman commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

@kbkpbot I am sorry, but I've reverted the change from this PR, because it caused the tests to fail, as well as the doom translation on the main V repo:
image

image

I'll make sure that this repo also has a CI, to prevent this from happening in the future.

After that, we can redo the changes and be sure that they do not break existing code from working.

spytheman added a commit that referenced this pull request Sep 12, 2025
@spytheman

Copy link
Copy Markdown
Contributor

It turns out that the already existing CI workflows, disabled themselves, because the previous commit on master was done more than 60 days ago 🤦🏻‍♂️ . It is now running on master again.

@kbkpbot

kbkpbot commented Sep 13, 2025

Copy link
Copy Markdown
Contributor Author

Or we need not fix c2v at all.
As at the end of c2v, it will call vfmt to format the code, which can do the int=>i32 there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants