FTP get() doesn't work

[lv37]

Describe the bug

FTP get() breaks the FTP instance

Expected Behavior

return the content of the files

Current Behavior

V panic: result not set (Cannot stablish data connection)
v hash: a9a94cf
/tmp/v_1002/main.15824724610745333533.tmp.c:9715: at _v_panic: Backtrace
/tmp/v_1002/main.15824724610745333533.tmp.c:9685: by panic_result_not_set
/tmp/v_1002/main.15824724610745333533.tmp.c:25290: by main__main
/tmp/v_1002/main.15824724610745333533.tmp.c:25754: by main

Reproduction Steps

module main

import net.ftp

fn main() {
	mut r := ftp.new()
	r.connect(ip)!
	r.login(user, pass)!

	println(r.get('/path/to/any/file')!) // works
	println(r.pwd()!) // should return '/', returns '226 Transfer complete.'
	println(r.get('/path/to/any/file')!) // returns error
}

Possible Solution

No response

Additional Information/Context

No response

V version

V 0.4.0 a9a94cf

Environment details (OS name and version, etc.)

V full version: V 0.4.0 52a055b.a9a94cf
OS: linux, Linux version 6.3.11-200.fc38.x86_64 (mockbuild@375e694195ec4df6b93501f3da7da879) (gcc (GCC) 13.1.1 20230614 (Red Hat 13.1.1-4), GNU ld version 2.39-9.fc38) #1 SMP PREEMPT_DYNAMIC Sun Jul 2 13:17:31 UTC 2023
Processor: 4 cpus, 64bit, little endian, Intel(R) Core(TM) i5-4310U CPU @ 2.00GHz

getwd: /home/user/Projects/v-testing/ftp
vexe: /home/user/.local/lib/v/v
vexe mtime: 2023-07-13 16:47:46

vroot: OK, value: /home/user/.local/lib/v
VMODULES: OK, value: /home/user/.vmodules
VTMP: OK, value: /tmp/v_1002

Git version: git version 2.41.0
Git vroot status: weekly.2023.27-63-ga9a94cfd
.git/config present: true

CC version: cc (GCC) 13.1.1 20230614 (Red Hat 13.1.1-4)
thirdparty/tcc status: thirdparty-linux-amd64 12f392c3

[JalonSolov]

Can you give a more complete example? For instance, what is ip?

[lv37]

ip is just my local ftp server's ip address: '192.168.1.3'

[JalonSolov]

Ok... after looking into the code, and running yours (with appropriate substitutions), I've discovered the following:

1. V's ftp.get() closes the data connection after at the end of the function. So in order to do a 2nd get, you have to connect and log in again.

2. The 226 Transfer complete message is one the code should have "eaten" for you, as it is a standard server response. If you run your code with -d debug, you'll see that the next thing returned is the dir you expected.

3. pwd() should not return /. It should return the user's full current path on the server. Why do you think it should return only /? For me, for instance, it returns /home/jalon, which is my home dir.