Test failed on OpenBSD for vlib/net/http/server_test.v

[lcheylus]

Describe the bug

With the latest version of V builded on OpenBSD current/amd64, test fail for vlib/net/http/server_test.v: ./v test vlib/net/http/server_test.v

Reproduction Steps

• Clone sources via Git on OpenBSD current/amd64
• Build V with clang version 16
• Run test: ./v test vlib/net/http/server_test.v

Expected Behavior

Run tests with no error.

Current Behavior

Test failed for vlib/net/http/server_test.v

$ ./v test vlib/net/http/server_test.v
---- Testing... ----
 FAIL  1436.753 ms vlib/net/http/server_test.v
         retry: 1
      comp_cmd: '/home/fox/dev/vlang.git/v' -skip-running   -o '/tmp/v_1000/tsession_9953d4b96f8_01J6BZ0SKPFMCMSZKJBBN6WWRX/0_0/server_test' '/home/fox/dev/vlang.git/vlib/net/http/server_test.v'
       run_cmd: '/tmp/v_1000/tsession_9953d4b96f8_01J6BZ0SKPFMCMSZKJBBN6WWRX/0_0/server_test'
failure code: 1; foutput.len: 2264; failure output:
---------------------------------------------------------------------------------------------------- retry: 0 ; max_retry: 0 ; r.exit_code: 1 ; trimmed_output.len: 2095
2024-08-28 09:43:25.771097 [INFO ] testsuite_begin
2024-08-28 09:43:25.771641 [WARN ] test_server_stop started
Server handler not set, using debug handler
Listening on http://0.0.0.0:9009/
2024-08-28 09:43:26.306881 [WARN ] test_server_stop finished
2024-08-28 09:43:26.306911 [WARN ] test_server_close started
accept() failed, reason: accept failed; skipping
2024-08-28 09:43:26.366875 [WARN ] test_server_close finished
2024-08-28 09:43:26.366915 [WARN ] test_server_custom_listener started
Server handler not set, using debug handler
accept() failed, reason: accept failed; skipping
2024-08-28 09:43:26.510787 [WARN ] test_server_custom_listener finished
2024-08-28 09:43:26.510814 [WARN ] test_server_custom_handler started
Listening on http://0.0.0.0:18197/
/home/fox/dev/vlang.git/vlib/net/http/server_test.v:128: ✗ fn test_server_custom_handler failed propagation with error: dial_tcp failed for address 0.0.0.0:18197
tried addrs:
        0.0.0.0:18197: net: socket error: 22; code: 22

  128 |         x := http.fetch(url: 'http://${server.addr}/endpoint?abc=xyz', data: 'my data')!
2024-08-28 09:43:26.588381 [WARN ] test_my_counting_handler_on_random_port started
2024-08-28 09:43:26.632309 [WARN ] server started
2024-08-28 09:43:26.632362 [INFO ] fetching from url: http://127.0.0.1:38267/count
2024-08-28 09:43:26.633418 [INFO ] my data, /count, counter: 1
2024-08-28 09:43:26.633950 [INFO ] my data, /count, counter: 2
2024-08-28 09:43:26.634814 [INFO ] my data, /count, counter: 3
2024-08-28 09:43:26.668562 [INFO ] my data, /count, counter: 4
2024-08-28 09:43:26.669335 [INFO ] my data, /count, counter: 5
2024-08-28 09:43:26.669360 [WARN ] server stopped
[/home/fox/dev/vlang.git/vlib/net/http/server_test.v:246] server.handler.counter: 5
2024-08-28 09:43:27.181469 [WARN ] test_my_counting_handler_on_random_port finished
2024-08-28 09:43:27.181511 [INFO ] testsuite_end
----
Failed command 1:    '/home/fox/dev/vlang.git/v' -skip-running   -o '/tmp/v_1000/tsession_9953d4b96f8_01J6BZ0SKPFMCMSZKJBBN6WWRX/0_0/server_test' '/home/fox/dev/vlang.git/vlib/net/http/server_test.v'
Summary for all V _test.v files: 1 failed, 1 total. Elapsed time: 7021 ms, on 1 job. Comptime: 5575 ms. Runtime: 1423 ms.

Possible Solution

No response

Additional Information/Context

No response

V version

V 0.4.7 1085f45

Environment details (OS name and version, etc.)

V full version: V 0.4.7 7baff15
OS: openbsd, 7.6, GENERIC.MP#279
Processor: 2 cpus, 64bit, little endian

getwd: /home/fox/dev/vlang.git
vexe: /home/fox/dev/vlang.git/v
vexe mtime: 2024-08-27 13:57:26

vroot: OK, value: /home/fox/dev/vlang.git
VMODULES: OK, value: /home/fox/.vmodules
VTMP: OK, value: /tmp/v_1000

Git version: git version 2.46.0
Git vroot status: weekly.2024.34-49-g05c7aa2c
.git/config present: true

CC version: OpenBSD clang version 16.0.6
thirdparty/tcc status: thirdparty-unknown-unknown de82a13

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

[lcheylus]

After some additional tests/debug...

In vlib/net/http/server_test.v there are 2 tests with error code 22 (net: socket error: 22; code: 22). These errors are propagated from vlib/net/tcp.c.v, function dial_tcp after connect.

On OpenBSD, connect for TCP returns EINVAL (error code = 22) if a TCP connection with a local broadcast, the all-ones or a multicast address as the peer was attempted (see https://man.openbsd.org/connect.2).

Code in sys/netinet/tcp_usrreq.c from OpenBSD kernel sources:
https://github.com/openbsd/src/blob/725adbd6a4cc1b359ee9dc2a55b4b06b5601bfb9/sys/netinet/tcp_usrreq.c#L662-L667

INADDR_ANY = IP addr 0.0.0.0 => see https://github.com/openbsd/src/blob/master/sys/netinet/in.h#L239

In vlib/net/http/server_test.v, the both tests test_server_custom_handler and test_host_header_sent_to_server have not set IP addr for the HTTP server => 0.0.0.0 is used by default and these tests fail on OpenBSD.

To fix this issue, in both tests, we need to set IP address for HTTP server.