cgen: fix auto str which expects ptr for ptr type#23553

felipensp · 2025-01-22T22:19:53Z

huly-for-github · 2025-01-22T22:20:01Z

Connected to Huly®: V_0.6-21981

spytheman

Very good work, but please add a test too, to prevent regressions.

Something like this works (with caveats):

module main

import net.html

fn main() {
	mut doc := html.parse('<body><div class="Box-footer"><div class="truncate">abc</div></div></body>')
	footer := doc.get_tags_by_class_name('Box-footer')[0]
	hrefs := footer.get_tag_by_class_name('Truncate')
	//dump(hrefs.str()) // cgen error
	println(hrefs) // ok
	// println(hrefs.str()) // runtime error, invalid memory access
	res := '${hrefs}'
	assert res == '&Option(&nil)'
}

spytheman · 2025-01-23T10:25:11Z

What is interesting is that println(hrefs.str()) works, when <div class="truncate"> is changed to <div class="Truncate">, because then the output of the string method changes.

felipensp · 2025-01-23T11:01:21Z

Very good work, but please add a test too, to prevent regressions.

Something like this works (with caveats):

module main

import net.html

fn main() {
	mut doc := html.parse('<body><div class="Box-footer"><div class="truncate">abc</div></div></body>')
	footer := doc.get_tags_by_class_name('Box-footer')[0]
	hrefs := footer.get_tag_by_class_name('Truncate')
	//dump(hrefs.str()) // cgen error
	println(hrefs) // ok
	// println(hrefs.str()) // runtime error, invalid memory access
	res := '${hrefs}'
	assert res == '&Option(&nil)'
}

Test added.

fix

ee66c72

spytheman approved these changes Jan 23, 2025

View reviewed changes

add test

5d10638

felipensp marked this pull request as ready for review January 23, 2025 10:57

spytheman merged commit 25f14d3 into vlang:master Jan 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

cgen: fix auto str which expects ptr for ptr type#23553