Skip to content

crypto.ecdsa: migrate ecdsa.PrivateKey.new() to use high level api#23640

Merged
spytheman merged 3 commits into
vlang:masterfrom
blackshirt:ecdsa-gen-migrate
Feb 4, 2025
Merged

crypto.ecdsa: migrate ecdsa.PrivateKey.new() to use high level api#23640
spytheman merged 3 commits into
vlang:masterfrom
blackshirt:ecdsa-gen-migrate

Conversation

@blackshirt

@blackshirt blackshirt commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

This PR was a continuation of migration step of this phase. In this PR, its only migrates one generator function ecdsa.PrivateKey.new() to use high level api. Its also still use old deprecated api to support old function that relies on EC_KEY function.
So, its does not changes the current behaviour, and the old opaque still avaialbles on there.
The other changes are:

  • Add required C declarations
  • Some bits of code reorganization to make its easy to read.
  • Add some constants to easy the access
  • Improves the function docs.

Its is..
Happy days..

@huly-for-github

Copy link
Copy Markdown

Connected to Huly®: V_0.6-22063

@blackshirt blackshirt changed the title crypto.ecdsa: Migrate PrivateKey.new() to use high level api crypto.ecdsa: migrate ecdsa.PrivateKey.new() to use high level api Feb 3, 2025
Comment thread vlib/crypto/ecdsa/ecdsa.v Outdated
Comment thread vlib/crypto/ecdsa/ecdsa.v Outdated
Comment thread vlib/crypto/ecdsa/ecdsa.v Outdated
Comment thread vlib/crypto/ecdsa/ecdsa.v Outdated

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit d30598b into vlang:master Feb 4, 2025
@blackshirt blackshirt deleted the ecdsa-gen-migrate branch February 6, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants