tools: reduce: improve parser for functions and add more loops to reduce more#23694
Merged
Conversation
|
Connected to Huly®: V_0.6-22114 |
spytheman
approved these changes
Feb 12, 2025
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Excellent work, very big improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the parser by enabling full function removal by considering it as a scope (before it left the signature and the brackets out of the scope)
Add an outer loop to the reducing process to clean as much code it can.
Before: lots leftover unnecessary functions that needed to be removed by hand
for my last MRE made by reduce for a 3k lines file: 66 lines
now: made by reduce for the same file: 9 lines (a const leftover, a struct used by the error producing function, and the function in itself)