Skip to content

tools: reduce: improve parser for functions and add more loops to reduce more#23694

Merged
spytheman merged 3 commits into
vlang:masterfrom
Eliyaan:reducing_more
Feb 12, 2025
Merged

tools: reduce: improve parser for functions and add more loops to reduce more#23694
spytheman merged 3 commits into
vlang:masterfrom
Eliyaan:reducing_more

Conversation

@Eliyaan

@Eliyaan Eliyaan commented Feb 11, 2025

Copy link
Copy Markdown
Member

Improve the parser by enabling full function removal by considering it as a scope (before it left the signature and the brackets out of the scope)
Add an outer loop to the reducing process to clean as much code it can.

Before: lots leftover unnecessary functions that needed to be removed by hand
for my last MRE made by reduce for a 3k lines file: 66 lines
now: made by reduce for the same file: 9 lines (a const leftover, a struct used by the error producing function, and the function in itself)

@huly-for-github

Copy link
Copy Markdown

Connected to Huly®: V_0.6-22114

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, very big improvement!

@spytheman spytheman merged commit 6ed56ee into vlang:master Feb 12, 2025
@Eliyaan Eliyaan deleted the reducing_more branch February 17, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants