crypto.ecdsa: migrate core routines for signing (and verifying)#23705
Merged
Conversation
|
Connected to Huly®: V_0.6-22124 |
Contributor
|
(should be merged after #23706, which changes the runners to Ubuntu 24.04, which has OpenSSL 3) |
Contributor
Author
Okey ..i saw |
Collaborator
|
I only see |
501bf0a to
0f76704
Compare
Contributor
|
(rebased over current master, which now runs the CI jobs on Ubuntu 22.04 and Ubuntu 24.04, which should have OpenSSL 3, instead of OpenSSL 1.1) |
…L 3.0 in /usr/local/, make sure that net.openssl and crypto.ecdsa are compatible
… OpenSSL is not installed by default
Contributor
Author
Thanks, i think its good to move the new one start from here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the main part of the migration efforts to the
crypto.ecdsamodule to support for the high level unobsoleted API. The old OpenSSL 1.1.1. series has reached its End of Life (EOL). As such it will no longer receive publicly available security fixes, see eol-of-ossl.1.1.1 for more detail, so, maybe better to just upgrade your openssl to the 3.x series.In this current PR, the main concerns was adding support to
.sign()and.verify()routines to support the new api. Its done by using some changes to the internal detail of the current one, ie, in the form:.sign()and.verify()methods..sign_messageinto.sign_digestto reflect underlying its wrapped. Its sign the digest internally.Thats its. thanks