cgen: fix codegen for nested if on return #23729
Merged
Merged
Conversation
|
Connected to Huly®: V_0.6-22147 |
spytheman
reviewed
Feb 15, 2025
| } | ||
|
|
||
| fn test_main() { | ||
| c := chan Message{} |
Contributor
There was a problem hiding this comment.
hm, why is c := chan Message{} needed, and why there is not a warning, that it is not used later?
spytheman
reviewed
Feb 15, 2025
Comment on lines
+204
to
+206
| defer { | ||
| g.last_if_option_type = tmp_if_option_type | ||
| } |
Contributor
There was a problem hiding this comment.
move the defer after line 197
Contributor
There was a problem hiding this comment.
it will be much less error prone that way, and it will work when the defer becomes scope based
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #23723