native: fix convert_int_to_string, add comments, more verbose#23743
Merged
Conversation
|
Connected to Huly®: V_0.6-22158 |
Member
Author
|
I fixed something but did not commit it yet |
Member
Author
|
I dont think spydr is the good person to review this PR as he is busy and not working on this backend anymore. |
JalonSolov
approved these changes
Feb 17, 2025
JalonSolov
left a comment
JalonSolov
left a comment
Collaborator
There was a problem hiding this comment.
All tests run fine here. Changes seem simple enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comments to help understanding the code.
Adds more
c.g.printlncalls to have an easier time in verbose native mode.Fixes the new test by terminating the buffer used in
convert_int_to_stringwith\0because it is assumed after when reversing it and when priting it (it tries to find it's lenght by searching\0). (I did not know how to name my test function.)Adds CLD when reversing the string to prevent the case where DF would be set and REPNE SCAS would do the opposite of what is expected.