strconv : Addition of Atoi8/16/32/64 helper, with their test.#23757
Merged
Conversation
|
Connected to Huly®: V_0.6-22172 |
Delta456
reviewed
Feb 18, 2025
spytheman
reviewed
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added atoi8, atoi16, atoi32 and atoi64 method. Added respective tests.Refactor some atoi() code to avoid code duplication. atoi64() uses a slightly different code, to keep using i64 types. Spytheman suggested to use math.i128 aritmetic. I didn't do it, but this can be done by anyone else.
I didn' t replicate Spytheman' s work around for MSVC compiler (msvc has a bug that treats just i64(min_int) as 2147483648).