crypto.ecdsa: cleans out old deprecated keypair opaque from the module.#23887
Merged
Conversation
|
Connected to Huly®: V_0.6-22290 |
spytheman
reviewed
Mar 9, 2025
…1 vlib/crypto/ecdsa/example/ecdsa_seed_test.v` from passing
spytheman
approved these changes
Mar 9, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


After this PR has been merged, all info's of high level opaque was already availables on the public and private key object, so, we can start out the removal of the deprecated ec_key opaque.
This PR contains this cleansup step in one-shoot commit. This cleansup significantly reduces the overall size line of the code, ie,
ecdsa.vfile, reduced from 905 lines down to 621 linesecdsa.c.vfile reduced from 200 down to 172 linesutil.vgets increased from 233 into 247, not too much addition, mostly for checking functionalityThis PR contains some bits in the forms of :
EC_KEYopaque from definitions and private and public key structureEC_KEYbased functionality and relies on the new high levelEVP_PKEYopaque.The good news is, on my test box, its now buildable with
-cstrictoptions, where previously, its would fail with these option because of deprecation error.Good days..thx