cli: add missing struct members to str() method and fix some comments#23893
Merged
Conversation
|
Connected to Huly®: V_0.6-22296 |
Contributor
|
I do not see a problem in adding more documentation to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some missing structure members to the str() method. I did not remove the deprecated members as I didn't know if that was something we should do now or postpone until later.
I am also considering writing up more descriptive and potentially tutorial type documentation in the README.md file as well as adding to the comments in the source. This would probably be fairly long and I didn't know if that level of documentation was appropriate for being in the source of vlib.