crypto.ecdsa: improves internal function of calc_digest_with_evpkey#23901
Merged
Conversation
|
Connected to Huly®: V_0.6-22303 |
blackshirt
changed the title
calc_digest_with_evpkey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current internal rotine
calc_digest_with_evpkeycall key size calculations step beforematchblock. This key size check only happens when you pass.with_custom_hashas an options., so, with default options, this calculation step was not needed in another options.This PR improves it a bit by moving out this key size calculation step goes down inside$\pm$ 5% improvement.
.with_custom_hashbranch of match block. In my benchmark, nothing significantly changes in the number, its only about