Skip to content

cgen: fix codegen for option return unwrapping on last statement#24030

Merged
spytheman merged 1 commit into
vlang:masterfrom
felipensp:fix_option_last_call_infix
Mar 24, 2025
Merged

cgen: fix codegen for option return unwrapping on last statement#24030
spytheman merged 1 commit into
vlang:masterfrom
felipensp:fix_option_last_call_infix

Conversation

@felipensp

Copy link
Copy Markdown
Member

Fix #24026

@huly-for-github

Copy link
Copy Markdown

Connected to Huly®: V_0.6-22423

Comment thread vlib/v/parser/parser.v
}
}
}
ast.InfixExpr {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole mark_last_call_return_as_used walking should happen in the checker, not in the parser

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 42538e1 into vlang:master Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C error when option is propagated in match as its expression value when operators are used

2 participants