Skip to content

v.vmod: add manifest encoder fn#24034

Merged
spytheman merged 2 commits into
vlang:masterfrom
gechandesu:vmod_encoder
Mar 29, 2025
Merged

v.vmod: add manifest encoder fn#24034
spytheman merged 2 commits into
vlang:masterfrom
gechandesu:vmod_encoder

Conversation

@gechandesu

Copy link
Copy Markdown
Contributor

This PR:

  • Adds encoder function for v.mod
  • Adds tests

@huly-for-github

Copy link
Copy Markdown

Connected to Huly®: V_0.6-22427

@spytheman

Copy link
Copy Markdown
Contributor

Why is it needed?

@gechandesu

Copy link
Copy Markdown
Contributor Author

Why is it needed?

I plan to use it in vpm for editing v.mod (with v install, v remove), it can also be used in scaffolding utilities like v init.

@gechandesu

Copy link
Copy Markdown
Contributor Author

I think the CI failure is not related to this PR, can you please rerun checks?

@spytheman

Copy link
Copy Markdown
Contributor

Done, although it may need rebasing over the current master too.

@spytheman

Copy link
Copy Markdown
Contributor

It failed again, I will rebase it.

@gechandesu

Copy link
Copy Markdown
Contributor Author

Hmm, failing again, I have a look bit later. Make MR a draft for now

@gechandesu gechandesu marked this pull request as draft March 25, 2025 22:23
Comment thread vlib/v/vmod/encoder.v Outdated
@gechandesu gechandesu marked this pull request as ready for review March 29, 2025 12:29

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 991b121 into vlang:master Mar 29, 2025
@gechandesu gechandesu deleted the vmod_encoder branch April 11, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants