Skip to content

db.mysql: use hardcoded const declare#24162

Merged
spytheman merged 1 commit into
vlang:masterfrom
kbkpbot:fix-mysql-const-declare
Apr 9, 2025
Merged

db.mysql: use hardcoded const declare#24162
spytheman merged 1 commit into
vlang:masterfrom
kbkpbot:fix-mysql-const-declare

Conversation

@kbkpbot

@kbkpbot kbkpbot commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

Fix issue #22086

@huly-for-github

Copy link
Copy Markdown

Connected to Huly®: V_0.6-22551

@JalonSolov

Copy link
Copy Markdown
Collaborator

Nice. One less C header to deal with. The file should also be renamed to just consts.v since there are no more C. references.

Final suggestion: add end of line comments showing the C constant, for continuity.

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit aba4a5a into vlang:master Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants