vtimeout: rewrite#24367
Merged
Merged
Conversation
|
Connected to Huly®: V_0.6-22743 |
spytheman
reviewed
Apr 30, 2025
Co-authored-by: Delyan Angelov <delian66@gmail.com>
spytheman
approved these changes
Apr 30, 2025
Contributor
Author
|
wait , it seems has problem under windows |
Contributor
Author
|
Tested under Linux/Windows |
Delta456
reviewed
Apr 30, 2025
| p.run() | ||
| if p.err != '' { | ||
| eprintln('Cannot execute: ${ctx.cmd_args.join(' ')}') | ||
| exit(if os.exists(ctx.cmd_args[0]) { 126 } else { 127 }) |
Member
There was a problem hiding this comment.
Is it possible to have the exit code constants? It would help to clarify.
Contributor
There was a problem hiding this comment.
The exit codes, are the ones of the timeout command in coreutils, and are unlikely to change. It is good for clarity to use comments or constants, but that can be done in another PR, while the functionality (killing the timeouted process) in this PR is desirable right away (it can simplify v reduce a bit for example).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #24366