Skip to content

math.big: reminder must respect the sign of dividend in % operator, a…#24489

Merged
spytheman merged 1 commit into
vlang:masterfrom
tankf33der:math-big-rem
May 15, 2025
Merged

math.big: reminder must respect the sign of dividend in % operator, a…#24489
spytheman merged 1 commit into
vlang:masterfrom
tankf33der:math-big-rem

Conversation

@tankf33der

@tankf33der tankf33der commented May 15, 2025

Copy link
Copy Markdown
Contributor

% operator of math.big does not respect sign of dividend.

Just copy-paste from / operator for sign management.
Now it can pass new test and 1M loop against libgmp.

@huly-for-github

Copy link
Copy Markdown

Connected to Huly®: V_0.6-22858

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 029564b into vlang:master May 15, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants