Skip to content

checker: cycle through all ast.ParExpr first in prefix_expr #24588

Merged
spytheman merged 5 commits into
vlang:masterfrom
Delta456:prefix_par_expr
Jun 3, 2025
Merged

checker: cycle through all ast.ParExpr first in prefix_expr #24588
spytheman merged 5 commits into
vlang:masterfrom
Delta456:prefix_par_expr

Conversation

@Delta456

@Delta456 Delta456 commented May 27, 2025

Copy link
Copy Markdown
Member

Fixes #24584

@huly-for-github

Copy link
Copy Markdown

Connected to Huly®: V_0.6-22953

@Delta456 Delta456 marked this pull request as draft May 27, 2025 07:52
@Delta456

Copy link
Copy Markdown
Member Author

I will do a PR to vlang/ui tomorrow to fix the CI.

@StunxFS

StunxFS commented May 28, 2025

Copy link
Copy Markdown
Contributor

Possibly out of scope for this PR, but an Expr.remove_paren() method would be great for removing the (), so it can be used anywhere you need to expr is SomeExpr

@Delta456

Copy link
Copy Markdown
Member Author

Possibly out of scope for this PR, but an Expr.remove_paren() method would be great for removing the (), so it can be used anywhere you need to expr is SomeExpr

It's a good idea @StunxFS. I am planning to make this method after this PR gets merged. It will help in all other occurrences.

@spytheman spytheman marked this pull request as ready for review June 3, 2025 07:01

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 3ad384e into vlang:master Jun 3, 2025
76 of 78 checks passed
@Delta456 Delta456 deleted the prefix_par_expr branch June 3, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

checker: wrapping mutable array in parenthesis circumvents checker

3 participants