parser, ast, fmt: convert "hello".str => c"hello" (fix #24635)#24652
Merged
Conversation
|
Connected to Huly®: V_0.6-23011 |
StunxFS
changed the title
js"string literal" + convert "hello".str => c"hello""hello".str => c"hello" (fix #24635)
spytheman
reviewed
Jun 6, 2025
spytheman
reviewed
Jun 6, 2025
StunxFS
changed the title
"hello".str => c"hello" (fix #24635)"hello".str => c"hello" (fix #24635)
JalonSolov
reviewed
Jun 6, 2025
JalonSolov
reviewed
Jun 6, 2025
Delta456
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler will now treat
"hello".stras if it were writtenc"hello"(orjs"hello"), which avoids creating an unnecessarystringobject. The formatter will also correct that piece of code by adding the necessary prefix.In addition to that, this PR depends on another PR (#24653) that will implement JS string literals (I thought V already supported them), now it will be possible to create native JS strings using a simple prefix (just like you would do with C).The JS backend is ignored.
Fix #24635.