jsgen: fix maps are always constructed using string keys (fix #24607 #24671)#24673
Merged
spytheman merged 2 commits intoJun 9, 2025
Conversation
|
Connected to Huly®: V_0.6-23030 |
spytheman
reviewed
Jun 9, 2025
Contributor
There was a problem hiding this comment.
Please add new test functions, instead of modifying the existing ones, unless there is a bug. That makes reviewing a lot easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24607 and #24671
The original problem is that map keys do not preserve the prototype methods of the original key values. The trick is to store the original key values, along with their prototype, so the following V code:
Is translated to this JS code:
Later, we can then use the "key values" for other purposes, such as returning the keys from the map.