native: preprocessed vars like EOF#24724
Merged
Merged
Conversation
spytheman
reviewed
Jun 15, 2025
spytheman
reviewed
Jun 15, 2025
| import strconv | ||
|
|
||
| const c_preprocessed = { | ||
| 'C.EOF': -1 |
Contributor
There was a problem hiding this comment.
hardcoding this does not seem scalable to me, is it just temporary?
Member
Author
There was a problem hiding this comment.
Until we are able to parse macros I do not see another way
Member
Author
There was a problem hiding this comment.
the map will be easily replaceable once we are able to get the macros
Collaborator
There was a problem hiding this comment.
Yes, hard-coding (whether done manually, or with c2v) is the only way to handle this without adding a C preprocessor to V.
Member
There was a problem hiding this comment.
Can you add a TODO note for this? It would help in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for variables like EOF