crypto.ecdsa: add support for OpenSSL on OpenBSD#24772
Merged
Merged
Conversation
Signed-off-by: Laurent Cheylus <foxy@free.fr>
Signed-off-by: Laurent Cheylus <foxy@free.fr>
On OpenBSD with gcc compiler, errors during tests => unable to find symbols with OpenSSL 3.4. Same tests OK on OpenBSD with tcc and clang (version 19). Signed-off-by: Laurent Cheylus <foxy@free.fr>
|
Connected to Huly®: V_0.6-23189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On OpenBSD, LibreSSL (https://www.libressl.org/) is used by default as TLS/crypto stack. This library is not fully compatible with OpenSSL v3.
OpenSSL v3.4 could be installed on OpenBSD via
eopenssl34package available in official ports tree.This PR adds support for OpenSSL version 3.4 (more recent version available for 7.7 release) on OpenBSD :
cmd/tools/modules/testing/common.v: add special case for OpenBSD to check if OpenSSL is presentvlib/crypto/ecdsa/ecdsa.c.v: add flags for OpenSSL to find OpenSSL v3.4 includes/libscrypto/ecdsa: issues to find OpenSSL symbols during link (unable to fix theses errors for now).Tests OK on OpenBSD/amd64 with tcc, clang and gcc for
vlib/crypto,vlib/net/ssl/andvlib/net/openssl/