markused: some cleanups and improvements#24959
Merged
Merged
Conversation
|
Connected to Huly®: V_0.6-23438 |
felipensp
changed the title
spytheman
reviewed
Jul 25, 2025
Comment on lines
+70
to
+72
| if ast_files[ast_files.len - 1].imports.len > 0 { | ||
| core_fns << 'builtin_init' | ||
| } |
Contributor
There was a problem hiding this comment.
That heuristic seems a bit hacky - you could have a freestanding program that imports its own modules, that do not use builtin too.
Doing a loop over ast_files and checking if at least one .mod == 'builtin' may be more reliable.
spytheman
approved these changes
Jul 25, 2025
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Excellent work.
Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.