Skip to content

cgen: fix asm stmt separators#25067

Merged
spytheman merged 3 commits into
vlang:masterfrom
kbkpbot:fix-asm-terminator
Aug 9, 2025
Merged

cgen: fix asm stmt separators#25067
spytheman merged 3 commits into
vlang:masterfrom
kbkpbot:fix-asm-terminator

Conversation

@kbkpbot

@kbkpbot kbkpbot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor
"mul %[lo], %[x], %[y];"
"umulh %[hi], %[x], %[y];"

This violates GCC/Clang's inline assembly syntax requirements. And this PR replaced semicolons with proper \n\t separators.

"mul %[lo], %[x], %[y]\n\t"
"umulh %[hi], %[x], %[y]\n\t"

@huly-for-github

Copy link
Copy Markdown

Connected to Huly®: V_0.6-23582

@kbkpbot kbkpbot changed the title cgen: fix asm stmt terminator cgen: fix asm stmt separators Aug 8, 2025
@spytheman

Copy link
Copy Markdown
Contributor

please add a test too

Comment thread vlib/v/slow_tests/assembly/stmt_separator_test.amd64.v Outdated

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 4e8b246 into vlang:master Aug 9, 2025
82 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants