parser: fix asm modifier parse#25072
Merged
Merged
Conversation
|
Connected to Huly®: V_0.6-23587 |
spytheman
reviewed
Aug 9, 2025
| mulq y | ||
| mov lo, rax | ||
| mov hi, rdx | ||
| ; =*m (lo) |
Contributor
There was a problem hiding this comment.
hm, that does not work with my local tcc 🤔:
./v -cc tcc -no-retry-compilation vlib/v/slow_tests/assembly/asm_test.amd64.v
Contributor
There was a problem hiding this comment.
=== C compilation error (from /home/delian/v/thirdparty/tcc/tcc.exe):
cc: /tmp/v_1000/asm_test.amd64.01K26VFD0GKTC5S097ADB5HCSA.tmp.c:8644:
error: unknown constraint '*'
=====================================================================
Contributor
There was a problem hiding this comment.
If you intend to add asm blocks for commonly used modules like math.bits or strconv, please use syntax that tcc can also process, otherwise it will make bootstrapping more difficult, and compilation for many programs a lot slower, due to the retrying and falling back to slower compilers like clang/gcc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #25070
Output constrains:
=r,=&r,+r,+&r,=m,=rm,=@ccl,=*rInput constrains:
r,0,rm,i,%r,*m