veb: fix generic field access from alias#25246
Merged
Merged
Conversation
|
Connected to Huly®: V_0.6-24845 |
spytheman
reviewed
Sep 6, 2025
spytheman
reviewed
Sep 6, 2025
Contributor
|
I think, that cgen should have produced instead of this: controllers_sorted = array_clone_to_depth(&global_app->controllers, 0);something like: controllers_sorted = array_clone_to_depth(&global_app->Controller.controllers, 0);but it did not, because of the alias. i.e. the proper fix would be to change cgen, to allow for an alias to a struct with embeds. You can test with: import veb
pub struct Context {
veb.Context
}
pub struct App {
veb.Middleware[Context]
veb.Controller
veb.StaticHandler
}
fn main() {
port := 9008
mut app := &App{}
veb.run[App, Context](mut app, port)
}(which does not use aliases), compared with the code from the issue |
spytheman
approved these changes
Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #25215