autofree,flag: fix double free in FlagParser free#25336
Merged
Conversation
spytheman
approved these changes
Sep 18, 2025
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Good work, however I think that the problem, may be in the args.clone() call, for []string , which does not clone the individual elements/strings of the array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9815.
It seems to me like calling these frees on
f.argsfreesos.argsonly on-autofree? Not sure why that would happen sinceos.argsis always cloned.I set it to
@[manualfree]here but it might actually end up leaking some memory since thenew_flag_parserfunction creates some clones, but it was preferable to freeing the variables before (and after) returning them?A few flag tests still fail with autofree but not in a way related to this issue.