x.crypto.chacha20: expands xchacha20 construction to support for 64-bit counter#25377
Merged
Conversation
|
Connected to Huly®: V_0.6-26066 |
blackshirt
changed the title
Contributor
|
Extensively tested. All passed. |
spytheman
reviewed
Sep 23, 2025
spytheman
reviewed
Sep 23, 2025
…e into readme file
spytheman
approved these changes
Sep 24, 2025
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Thank you @blackshirt .
Contributor
Author
Thank you @spytheman for suggestion and reviews. There are patch in queue related to apply precomputation technique for 64-bit counter variant, like we do on 32-bit counter variant, but, i dont know, is this should be sent or not?. In my test, it improves a small of bit, but not too much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch expands eXtended ChaCha20 construction to support for 64-bit counter, completes support for the existing 32-bit counter construct.
@spytheman, @tankf33der: can you look into it ?
Cheers,
thanks