os: propagate POSIX error code from os.ls/1 and os.rmdir_all/1 on UNIX-like systems#25392
Merged
Conversation
spytheman
reviewed
Sep 27, 2025
| dir := unsafe { C.opendir(&char(path.str)) } | ||
| if isnil(dir) { | ||
| return error('ls() couldnt open dir "${path}"') | ||
| return error_posix(msg: 'ls() couldnt open dir "${path}"') |
Contributor
There was a problem hiding this comment.
This is not safe, since the C.errno could be changed during the string interpolation in the argument.
Contributor
There was a problem hiding this comment.
you can call e := last_error() separately, if you need to include details about the exact reason, and then access its e.code() and e.msg() to compose the final error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return the error code from
os.ls/1andos.mkdir_all/1to enable detailed error handling e.g. you can now differ ENOENT (no such file or directory) and other possible I/O errors: