net.websocket: fix incorrect formatting for custom headers during handshake#25397
Merged
Merged
Conversation
|
Connected to Huly®: V_0.6-26084 |
Contributor
|
Afaik Can the That will change the handshake request, and hopefully can serve as a regression test, without needing to add a separate test that does a websocket request to a separate external sertice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix that makes custom headers during ws client handshake actually valid
if for example a server requires the
Originheader to be set, before this fix, said server would've denied the connection even if the value was correct and the header was there, just because the header isn't valid, but now since it's valid it no longer failsi didn't make a specific test for this fix in particular because it just adds a space to a string and the only valid testing option i know of is a very specific domain (not local) and i wouldn't want to have an external connection in a test like that