parser: fix eval fixed array size#25409
Merged
Merged
Conversation
Contributor
I agree completely - the checker is more suitable to calculate it. |
spytheman
reviewed
Sep 28, 2025
| } | ||
| } | ||
| ast.Ident { | ||
| if mut const_field := p.table.global_scope.find_const(size_expr.full_name().all_after('builtin.')) { |
Contributor
There was a problem hiding this comment.
why is the .all_after('builtin.') needed ?
blackshirt
pushed a commit
to blackshirt/v
that referenced
this pull request
Oct 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #25404
BTW, I think we should remove
eval_array_fixed_sizes()fromparser. Because inparser, it has no full information, for example,[2][const_a - sizeof(T)]int{},sizeof(T)is ready inchecker. Andcheckeralso has it's owneval_array_fixed_sizes().