parser: smart detect or {} inside loop when using c <-val #25435
Merged
Conversation
|
Connected to Huly®: V_0.6-26119 |
Member
|
@Delta456 why draft still? |
Member
Author
VLS used to fail, as my fix was messing up code generation. Now the CI seem to pass? That is strange. |
Contributor
|
vlang/vls had recent changes, perhaps they served as a workaround |
Contributor
|
I'll rebase the changes here over our current master, to check if everything is ok, and if it is, I'll merge it. |
spytheman
force-pushed
the
for_channel_or_block
branch
from
b0fe87f to
1768552
Compare
Member
Author
|
The CI still fails https://github.com/vlang/v/actions/runs/18598848534/job/53032048538?pr=25435. I haven't got time to fix this issue lately. I would appreciate if someone fixes it. |
StunxFS
reviewed
Oct 25, 2025
Delta456
force-pushed
the
for_channel_or_block
branch
from
1768552 to
5d5b812
Compare
…ath { sin, cos }`"
This reverts commit ddf0468.
Delta456
force-pushed
the
for_channel_or_block
branch
from
5d5b812 to
b89000f
Compare
Member
Author
|
Thanks @StunxFS for the fix 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24550