crypto.cipher: fix decryption in CBC mode, add test#25584
Merged
Conversation
spytheman
approved these changes
Oct 24, 2025
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Excellent work.
It was not a typo imho in the sense, that it was not just a small mismatch on the letters. The old code had a clear semantic bug.
spytheman
reviewed
Oct 24, 2025
|
|
||
| fn test_aes_cbc_double() { | ||
| orig1 := []u8{len: 64, init: index} | ||
| orig2 := []u8{len: 16, init: index} |
Contributor
There was a problem hiding this comment.
I am not sure if it may have been better to use a more varied content, something like init: index*10 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test against
golangfailed and a trivial audit showed that a typo occurred again.Worked for a long time on the test to properly trigger the decryption error.
This new test cannot pass on
master.Please review my work and approve.