x.crypto.chacha20poly1305: small cleans up and improves safety check#25631
Merged
Conversation
…her level caller in psiv mode
… array into the fixed one, and adapts the artefacts tho use this changed.
Contributor
|
All passed. |
spytheman
approved these changes
Oct 31, 2025
Contributor
|
Thank you @blackshirt 🙇🏻 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some while for looking it back, i think there are some deficiency that can be improved on. Two's main changes on this pr was
precompflag todoneflag. precomputation phase for deriving keys was already done and stored on themac_key,enc_keyandpoly1305instance set on psiv creation. By changing todoneflag to mark this psiv construct as unusable anymore and effectively preventing to call.encryptor.decrypt. so we can just returns error if it happens, instead of panic.keyfield. Its not used on any other places. Its already stored on derived keys, so we can safely remove this out.vmemsetcall.encryptand.decryptcall to aware ofdoneflagThanks,
Cheers.