io.string_reader: fix read_line(), add tests#25704
Merged
Merged
Conversation
spytheman
approved these changes
Nov 9, 2025
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Excellent work.
Thank you 🙇🏻 .
Contributor
|
@tankf33der what do you think of making |
Contributor
Author
I will very soon get to these functions and consider this idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
read_line()function works quite well, but managed to break the newline handler and create a working test on how to reproduce this.Only the
test_read_line_8()fails on themasterbranch.