math.unsigned: fix put_bytes()#25718
Merged
Merged
Conversation
Contributor
There is no problem - you can import whatever you need in the tests; it does not affect other users of the module (each _test.v file is compiled as a separate program, independent from the rest). |
spytheman
approved these changes
Nov 12, 2025
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Excellent work.
Thank you @tankf33der .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two-line patch speaks for itself and test can not pass on
master.p.s. I'm not sure if I have the right(s) to include and rely on the
randmodule for random numbers, but it can always be redone.