Skip to content

builtin,os: fix windows execute ANSI encoding result#25736

Merged
spytheman merged 5 commits into
vlang:masterfrom
kbkpbot:fix-windows-execute-encoding
Nov 16, 2025
Merged

builtin,os: fix windows execute ANSI encoding result#25736
spytheman merged 5 commits into
vlang:masterfrom
kbkpbot:fix-windows-execute-encoding

Conversation

@kbkpbot

@kbkpbot kbkpbot commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix issue #25727

image

@kbkpbot kbkpbot linked an issue Nov 14, 2025 that may be closed by this pull request
Compilation with msvc shows garbled characters in error messages #25727
Closed
spytheman
spytheman reviewed Nov 14, 2025
View reviewed changes
Comment thread vlib/os/os_windows.c.v Outdated
@kbkpbot kbkpbot mentioned this pull request Nov 15, 2025
Merged
spytheman pushed a commit that referenced this pull request Nov 15, 2025
@kbkpbot
v.builder: fix .vsh mode doing an implicit import os, now only fo…
1963632 
…r .vsh file itself (fix issue spotted in #25736) (#25745)
@kbkpbot

kbkpbot commented Nov 15, 2025

Copy link
Copy Markdown
Contributor Author

As vlib/v/checker/tests/invalid_utf8_string.vv contains invalid utf-8 string, so under windows, this PR will treat it as an ANSI encoding string. This will cause the test fail. I think we can remove the test.

_ := '测试txt'

@spytheman spytheman force-pushed the fix-windows-execute-encoding branch from 88ba4a7 to 328b7db Compare November 15, 2025 18:45
@spytheman

spytheman commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

I've skipped vlib/v/checker/tests/invalid_utf8_string.vv on master for msvc in vlib/v/compiler_errors_test.v .

spytheman
spytheman approved these changes Nov 15, 2025
View reviewed changes

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.
Thank you @kbkpbot 🙇🏻 .

@kbkpbot

kbkpbot commented Nov 16, 2025

Copy link
Copy Markdown
Contributor Author

As this PR fix os.execute() result string under windows, not only related to msvc.

@spytheman spytheman merged commit 8094150 into vlang:master Nov 16, 2025
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@spytheman spytheman spytheman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compilation with msvc shows garbled characters in error messages

2 participants

@kbkpbot @spytheman