checker: Allow explicit sumtype to option casts#25812
Merged
Merged
Conversation
spytheman
approved these changes
Nov 22, 2025
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Excellent work.
Thank you @imperivox 🙇🏻 .
Contributor
|
@imperivox you have to also run |
Contributor
Author
|
It should be good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #25796 by allowing explicit casts from a sum type
Tto its option type?T, just like with non-sum types.Before this, code like
?SumType(SumType(u16(0)))failed becauseSumType -> ?SumTypewasn’t allowed.The fix adds a check that lets you cast to
?Twhen the value is exactly typeT, even ifTis a sum type.