math: add tests for vec2,3,4 perpendicular

[Linklancien]

This PR fix an issue cause because of the change of the project function

It also add some test to assure that won't happend again

[Linklancien]

It may conflict with #25841 because of the inversion of u and v

[tankf33der]

I am firmly certain that this PR is suspicious.

@Linklancien
project() is incorrect itself for vec2,3,4.

[Linklancien]

The main issue I wanted to fix was to introduce a tests for the the perpendicular function to avoid regressions

[tankf33der]

@Linklancien

Our perpendicular() is correct. Proof is below:

namespace glm
{
	template<typename genType>
	GLM_FUNC_QUALIFIER genType perp(genType const& x, genType const& Normal)
	{
		return x - proj(x, Normal);
	}
}//namespace glm

[Linklancien]

@Linklancien

Our perpendicular() is correct. Proof is below:

namespace glm
{
	template<typename genType>
	GLM_FUNC_QUALIFIER genType perp(genType const& x, genType const& Normal)
	{
		return x - proj(x, Normal);
	}
}//namespace glm

Yes it is
It just lack tests

[spytheman]

This PR does not pass its tests either before or after rebasing on #25841 (which is now merged).

Imho there is a bug somewhere.

[Linklancien]

Thoses push should be good and only add test for perpendicular

[JalonSolov]

You need to v fmt your tests.

[Linklancien]

Oh no

[Linklancien]

I forgot to fmt

[JalonSolov]

Something useful if you're working on V itself...

From CONTRIBUTING.md:

3.1 (optional) Run these commands, which ensure that all your code will be
automatically formatted, before committing:

cp cmd/tools/git_pre_commit_hook.vsh .git/hooks/pre-commit
chmod 755 .git/hooks/pre-commit

[JalonSolov]

Side note: Perhaps that pre-commit trigger should be set by default in the V repo. Would solve this particular "headache" for new people, and perhaps help some not-so-new.

[spytheman]

Side note: Perhaps that pre-commit trigger should be set by default in the V repo. Would solve this particular "headache" for new people, and perhaps help some not-so-new.

how? should it be put in the makefiles?

[Linklancien]

Something useful if you're working on V itself...

From CONTRIBUTING.md:

3.1 (optional) Run these commands, which ensure that all your code will be
automatically formatted, before committing:

cp cmd/tools/git_pre_commit_hook.vsh .git/hooks/pre-commit
chmod 755 .git/hooks/pre-commit

I did read that but didn't understand where to execute the command even if it seemed really usefull

[spytheman]

I am using the git hook for several years at this point daily, so I guess it is stable enough (I only occasionally have to pass --no-verify to git commit to skip it, when debugging issues in vfmt itself, but most people will not have to debug vfmt itself) 🤔 .

[spytheman]

I did read that but didn't understand where to execute the command even if it seemed really usefull

It has to be done in a shell where you have done cd /root/of/your/V_repo once.
I.e. you have to be in the top level folder, that contains the .git folder for the V repository.

[JalonSolov]

Side note: Perhaps that pre-commit trigger should be set by default in the V repo. Would solve this particular "headache" for new people, and perhaps help some not-so-new.

how? should it be put in the makefiles?

That would be one way, for certain.

[spytheman]

It looks good to me now, and it is ready to be merged.

@tankf33der what do you think?

[tankf33der]

The main thing is that our perpendicular() function is correct and new tests never hurt.

[tankf33der]

@spytheman lets merge.

[spytheman]

Thank you @Linklancien 🙇🏻 .
Thank you @tankf33der 🙇🏻 .