crypto.cipher: fix xor_key_stream() for OFB mode, add test#25844
Merged
Conversation
Contributor
Author
|
@blackshirt, @einar-hjortdal - please take a look. |
Contributor
Author
|
Only this patch allows run test successfully against |
Contributor
|
Seems good to me, I would maybe add in the comments how the test array was obtained (openssl version etc.). But that's minor and may be unnecessary. |
Contributor
Not really true for the expert thing ..it share the same thiing with the others, just some user.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests showed that byte-by-byte operation does not work correctly, while block-by-block operation works properly in OFB mode.
Trivial typo in the code that was not tested, proof #1 and #2.
The test vector was created using
openssl.