Skip to content

parser: disallow untyped chan#25854

Merged
spytheman merged 1 commit into
masterfrom
chan-parser
Nov 29, 2025
Merged

parser: disallow untyped chan#25854
spytheman merged 1 commit into
masterfrom
chan-parser

Conversation

@dy-tea

@dy-tea dy-tea commented Nov 28, 2025

Copy link
Copy Markdown
Member

Fixes #25818.

Doesn't appear to affect the the functions defined on chan.

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it handle &chan and ?chan too?

@dy-tea

dy-tea commented Nov 29, 2025

Copy link
Copy Markdown
Member Author

Oh looks like I missed those. Simple fix, will add tests as well.

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.
Thank you @dy-tea 🙇🏻 .

@spytheman spytheman merged commit 6aa81fa into master Nov 29, 2025
167 checks passed
@spytheman spytheman deleted the chan-parser branch December 9, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ast: missing type info for chan

2 participants