math.complex: fix log(), replace tests#25863
Merged
Merged
Conversation
Contributor
Author
|
I will handle this errors. |
Contributor
Author
|
The test showed that comparing |
spytheman
approved these changes
Nov 30, 2025
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Good find. Thank you @tankf33der 🙇🏻 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrect handling of
WolframAlphaparameters and mathematical notation led to the error not being detected during development and testing.Some systems have the base as the first parameter of the function.
vlanghas it second:Great

mpmathhas it second too and with correct formula:But

WolframAlphahas it first:Had to remove all current tests and replace them with one that is consistent with
cmathfrom the Python distribution and thempmathlibrary.p.s. I wrote tests for the entire
complexmodule againstcomplex.hfile for the functions that match, and other functions are awaiting their turn for manual testing.