Skip to content

pkgconfig: support multiple packages per line#25870

Merged
spytheman merged 1 commit into
vlang:masterfrom
dy-tea:pkg-error
Dec 1, 2025
Merged

pkgconfig: support multiple packages per line#25870
spytheman merged 1 commit into
vlang:masterfrom
dy-tea:pkg-error

Conversation

@dy-tea

@dy-tea dy-tea commented Dec 1, 2025

Copy link
Copy Markdown
Member

Fixes #12944.

Current behavior:
image

@dy-tea dy-tea force-pushed the pkg-error branch 3 times, most recently from e2695f9 to 4878987 Compare December 1, 2025 01:23
@dy-tea

dy-tea commented Dec 1, 2025

Copy link
Copy Markdown
Member Author

Added some logic so it also checks for flags.

@spytheman

Copy link
Copy Markdown
Contributor

The documentation states explicitly that Multiple modules can be passed - https://docs.vlang.io/v-and-c.html##pkgconfig .

@dy-tea

dy-tea commented Dec 1, 2025

Copy link
Copy Markdown
Member Author

Maybe I need to change the docs as well then. Because currently you can't.

Or allow multiple per line.

@dy-tea dy-tea changed the title parser: add error for #pkgconfig with multiple packages pkgconfig: support multiple packages per line Dec 1, 2025
@dy-tea

dy-tea commented Dec 1, 2025

Copy link
Copy Markdown
Member Author

Fixed so it instead supports multiple packages per line.

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dy-tea 🙇🏻.

I could not think of an easy way to test it reliably on the CI for now 🤔.

@spytheman spytheman merged commit 3459806 into vlang:master Dec 1, 2025
72 of 73 checks passed
@dy-tea

dy-tea commented Dec 1, 2025

Copy link
Copy Markdown
Member Author

Yeah wasn't sure about it either. Would likely have to check for a package already on the CI.

@dy-tea dy-tea deleted the pkg-error branch December 1, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pkgconfig: error without description

2 participants