veb: fix veb silently fails to bind a handler when result type is not veb.Result#25973
Merged
Conversation
spytheman
reviewed
Dec 15, 2025
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Welcome to the V repo, and thanks for your excellent PR.
I think it is a very good addition, and it can help prevent a lot of confusion (as seen on Discord and here).
Contributor
|
I played a bit with it, and discovered, that we are missing a source location information in the metadata for the method, but it would have been useful for situations like this 🤔 . For example, I got: If we had a location information, then the error message could become: I'll see what can be done about it asap. |
Contributor
|
With latest V 22fafd6, the error is now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential Fix for #25970.
Fixes an issue where Veb would silently fail to bind a handler when the return type of a handler function is not veb.Result (and is, for example,
!veb.Result). I've also added tests to cover this. I'm happy to take a different approach if needed, too. This is my first contribution to V and am still learning the ropes.Changes: