wasm: fix export pub fns in main module when targeting wasi#26041
Merged
spytheman merged 1 commit intoDec 20, 2025
Conversation
Contributor
|
Excellent work, thank you. |
spytheman
approved these changes
Dec 20, 2025
Contributor
|
The test is in #26048 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #25630
The WASM backend was only exporting pub functions when the target OS was
.browser. When compiling with -b wasm (which defaults to .wasi target), pub functions were not exported. This prevented tools like wasmer from invoking the functions.I've updated the logic to determine public exports in the main module to also include the
.wasitarget. Not entirely sure what a test for this would look like without adding a dependency on something like wasmer (or parsing the generated output file, maybe?)