cgen,slow_tests: add riscv64 inline asm support, add tests#26050
Merged
Conversation
Contributor
|
Please also add |
spytheman
approved these changes
Dec 20, 2025
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Thank you @tankf33der .
Excellent work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am conducting an audit of all inline assembler support for each architecture and tests, and will create PRs as I find things that need to be fixed.
Lets add
riscv64inline asm support.Patch and tests created on real riscv64 environment (ubuntu 24.04.3) under qemu.
Tests works under gcc and clang.
One could nitpick about the test file name
asm_test.rv64.v, but I chose the name based on the actual architecture name inside sources, all other numerous variations are aliases.