x.json2: code cleanup, add more tests#26064
Merged
Merged
Conversation
spytheman
approved these changes
Dec 21, 2025
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Excellent work.
Thank you for the cleanup 🙇🏻 .
spytheman
reviewed
Dec 21, 2025
Contributor
|
hm, did the additional tests removed in d1d431b, fail on some of the platforms (the ones in test_float_precision) ? |
Contributor
Author
|
Sorry, I made a mistake. I misremembered and thought the floating-point issue had been detected in the PR #26060. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup of PR #26033