toml: add compliance up until official toml-lang/toml-test@c6a78f1#26067
Merged
spytheman merged 1 commit intoDec 21, 2025
Merged
Conversation
toml: add compliance up until official toml-lang/toml-test@c6a78f1
larpon
force-pushed
the
toml/bump-toml-lang-compliance-tests-to-c6a78f1
branch
from
50a9a73 to
4da7891
Compare
spytheman
reviewed
Dec 21, 2025
spytheman
reviewed
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds compliance with the official TOML test suite up until and including toml-lang/toml-test@c6a78f1 (TOML v1.0)
I had to introduce a new parser helper array (
immutable) to help detect immutability issues.I'm starting to think the TOML parser might have been better off keeping track of scopes and types as well since some of the fixes here feels more like shoehorning to me but let's see what the future holds.
I'm hoping to fix some "timezone overflow" checks (added in commits after toml-lang/toml-test@c6a78f1) in a follow up PR which should bring us closer to where TOML v1.1 support was pushed to the test suite.