Skip to content

checker,parser: multifile gotodef support for -line-info#26167

Merged
spytheman merged 4 commits into
vlang:masterfrom
dy-tea:gotodef
Dec 27, 2025
Merged

checker,parser: multifile gotodef support for -line-info#26167
spytheman merged 4 commits into
vlang:masterfrom
dy-tea:gotodef

Conversation

@dy-tea

@dy-tea dy-tea commented Dec 27, 2025

Copy link
Copy Markdown
Member

Jumping to a definition in another file of the same module would not always work. Here I add a fix so -line-info properly reports this. Small test is also included.

Comment thread vlib/v/checker/checker.v Outdated
Comment thread vlib/v/tests/vls/multifile_gotodef_test.v Outdated

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.
Thank you @dy-tea for improving vls & v's integration and functionality 🙇🏻 .

@spytheman

Copy link
Copy Markdown
Contributor

phew, 2 of the windows jobs finally passed 🥳

@spytheman spytheman merged commit 29d0f7a into vlang:master Dec 27, 2025
84 checks passed
@dy-tea dy-tea deleted the gotodef branch December 28, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants